Repository navigation
Set the backlog metrics interval through the generic override - #2535
Merged
2 commits merged intoOct 8, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
francoisferrand
approved these changes
Sep 17, 2026
benzekrimaha
approved these changes
Sep 17, 2026
The generic backbeat.configurationOverrides map reaches backbeat as environment variables, and 9.5 answers most of those names from an entrypoint that rewrites conf/config.json in place. The operator mounts that directory read only, so the container dies before it serves anything: KAFKA_BACKLOG_METRICS_INTERVALS is one of the 57 names rewritten that way, which is what failed this suite eight runs in a row. 9.6 deleted the entrypoint and reads those names from the configuration schema itself (BB-808), where joi also coerces the value, so the interval arrives as the number the schema declares rather than as a string. That the operator passes them to a backbeat that cannot take them is ZKOP-605. Issue: ZENKO-5359
backlogMetricsIntervalSeconds was a dedicated CR field, added by zenko-operator#626 and reverted by #633 right after v1.8.16 in favour of the generic backbeat.configurationOverrides map. The two spellings never coexist in a released operator: v1.8.16 knows only the field, and every 1.8 release after it knows only the override. So the e2e config and the operator pin have to move together, and bumping the operator without this change breaks the whole suite on a rejected field. KAFKA_BACKLOG_METRICS_INTERVALS is backbeat's declared env alias for kafka.backlogMetrics.intervalS, so the value reaches the same config key with the same unit the removed field used -- as of 9.6, bumped just before this, which is also the first release the map can be passed to at all. It is set on the four consumers whose lag the lifecycle conductor waits on. Issue: ZENKO-5359
delthas
force-pushed
the
improvement/ZENKO-5359/backbeat-configuration-overrides
branch
from
September 21, 2026 13:34
99c71b4 to
2ab135e
Compare
Contributor
Author
|
/approve |
Contributor
Author
|
!done 5h |
Contributor
Build failedThe build for commit did not succeed in branch improvement/ZENKO-5359/backbeat-configuration-overrides The following options are set: approve |
Contributor
Author
|
Replaced by #2546 |
bert-e
deleted the
improvement/ZENKO-5359/backbeat-configuration-overrides
branch
October 8, 2026 18:07
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backbeat.backlogMetricsIntervalSecondsis a dedicated CR field the operator no longer has: scality/zenko-operator#626 added it, scality/zenko-operator#633 reverted it right afterv1.8.16in favour of the genericbackbeat.configurationOverridesmap.The two spellings never coexist in a released operator:
backlogMetricsIntervalSecondsbackbeat.configurationOverridesv1.8.16ZenkoSpecSorbetv1.8.17So the config and the operator pin have to move together, and bumping the operator without this change fails the whole suite on a rejected field. Hence both in one commit.
The override also needs a backbeat that can take it. The map arrives as environment variables, and 9.5 answers most of those names from an entrypoint that rewrites
conf/config.jsonin place — a directory the operator mounts read-only, so the container dies before it serves anything.KAFKA_BACKLOG_METRICS_INTERVALSis one of the 57 names rewritten that way, which is what failed this branch eight runs in a row. 9.6 deleted the entrypoint and reads those names from the configuration schema itself (BB-808), so the bump to9.6.0-preview.1comes first here. That the operator passes these to a backbeat that cannot take them is ZKOP-605.KAFKA_BACKLOG_METRICS_INTERVALSis backbeat's declared env alias forkafka.backlogMetrics.intervalS(intervalS: joi.number().default(60).meta({ env: 'INTERVALS' })), so the value reaches the same key with the same unit — seconds — as the removed field did, with joi coercing"5"to the number the schema declares. It is set on the four consumers whose lag the lifecycle conductor waits on.9.5.19.6.0-preview.1v1.8.16v1.8.17Split out of #2532, which carries the same change but is blocked on a zenko-operator 1.9 PR and so cannot land on this timeline.
Issue: ZENKO-5359