Skip to content

ARSN-665: Name only the requested key ARN when rejecting a key from an unconfigured KMS - #2738

Open
dvasilas wants to merge 3 commits into
development/8.6from
improvement/ARSN-665-name-only-requested-key-arn
Open

dvasilas wants to merge 3 commits into
development/8.6from
improvement/ARSN-665-name-only-requested-key-arn

Conversation

@dvasilas

@dvasilas dvasilas commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Context: This PR is part of the work to allow a deployment to configure several KMSs.

When a key ARN names a KMS that is not configured, the InvalidArgument description lists the ARN prefix of every configured KMS. With several KMSs, it discloses their provider names to end users.
The description now names only the requested ARN.

Note to reviewers: The first commit is formatting with Prettier.

@bert-e

bert-e commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue ARSN-665 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.1

Please check the Fix Version/s of ARSN-665, or the target
branch of this pull request.

Comment thread lib/network/KMSInterface.ts Outdated
@bert-e

bert-e commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.39%. Comparing base (765bda8) to head (3e799f5).

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.6    #2738   +/-   ##
================================================
  Coverage            75.39%   75.39%           
================================================
  Files                  226      226           
  Lines                18633    18634    +1     
  Branches              3895     3895           
================================================
+ Hits                 14048    14049    +1     
  Misses                4580     4580           
  Partials                 5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…n unconfigured KMS

The error reaches any S3 client, and listing the configured KMSs discloses their provider names.
@dvasilas
dvasilas force-pushed the improvement/ARSN-665-name-only-requested-key-arn branch from de896e3 to 3e799f5 Compare October 19, 2026 14:48

@fredmnl fredmnl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: I'm good with current form but validateKeyDetail sounds to me like we should have checked beforehand that the key exists. I know this choice predates your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants