Repository navigation
Conversation
Contributor
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.6 #2738 +/- ##
================================================
Coverage 75.39% 75.39%
================================================
Files 226 226
Lines 18633 18634 +1
Branches 3895 3895
================================================
+ Hits 14048 14049 +1
Misses 4580 4580
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…n unconfigured KMS The error reaches any S3 client, and listing the configured KMSs discloses their provider names.
dvasilas
force-pushed
the
improvement/ARSN-665-name-only-requested-key-arn
branch
from
October 19, 2026 14:48
de896e3 to
3e799f5
Compare
fredmnl
approved these changes
Oct 20, 2026
fredmnl
left a comment
Contributor
There was a problem hiding this comment.
Nitpicking: I'm good with current form but validateKeyDetail sounds to me like we should have checked beforehand that the key exists. I know this choice predates your change.
nicolas2bert
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: This PR is part of the work to allow a deployment to configure several KMSs.
When a key ARN names a KMS that is not configured, the
InvalidArgumentdescription lists the ARN prefix of every configured KMS. With several KMSs, it discloses their provider names to end users.The description now names only the requested ARN.
Note to reviewers: The first commit is formatting with Prettier.