Repository navigation
Do not warn on every run when the sudoversion fact resolves - #347
Merged
Merged
Conversation
miharp
added a commit
to miharp/control-repo
that referenced
this pull request
Oct 8, 2026
10.0.1 removes the per-run Facter.warn that 10.0.0 added to the sudoversion fact (saz/puppet-sudo#347), which is why #80 kept 9.0.2. The sudoversion and new sudo facts only call Facter::Core::Execution.which and .execute, so 9.x agents stop warning about the deprecated Facter::Util::Resolution API from this module. puppet/yum is now the only module here that still triggers those warnings. 10.0.0's breaking changes drop Debian 11 and add a structured sudo fact next to sudoversion; nothing here reads either fact. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facter.warnin thesudoversionfact fires on every fact resolution, so every user of the module sees the deprecation warning on every run whether or not they use the fact. Removed it and documented both facts in the README instead. The fact itself is unchanged.Fixes #346