Repository navigation
Add regression coverage for Todo placement on offset displays - #1919
Merged
Merged
Conversation
culpen90
marked this pull request as ready for review
October 17, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo placement must preserve the target display's vertical offset when converting from AppKit to Accessibility coordinates. Extract the existing placement step and allow the primary display's top edge to be supplied explicitly so tests can verify the frame sent to Accessibility without arranging physical displays. Existing placement behavior is preserved.
Add seven regression tests covering displays above and below the primary display, horizontally arranged displays with vertical offsets, both sidebar sides, gaps, Dock/menu insets, and percentage widths.
Validation: the Debug app builds and all 12 focused tests pass with:
Fixes #535. The coordinate correction is already present; these tests protect it from regression.