Repository navigation
Conversation
For programs that build the interpreter from the tables themselves (Interpreter::new) and are built with a stable compiler, such as a UEFI boot manager reading the battery. The allocator API, which needs nightly, is only used by the `platform` module and `Interpreter::new_from_platform`. They are now behind a `platform` feature, on by default; `default-features = false, features = ["aml"]` builds with a stable compiler. CI builds that configuration, so it keeps working.
Contributor
|
Nice idea, thanks @ogoffart. I have also wondered about using a stable compiler, but didn't realise it'd be so straightforward 😆 One question: does the "alloc" feature actually do anything now? Is it worth just removing it? |
With the platform module behind its own feature, `alloc` only enabled `extern crate alloc`, which only the aml and platform features need: it did nothing on its own. The crate now uses alloc when either is on. CI's i686 build without the interpreter uses `platform` instead.
Contributor
Author
|
yes that's true, the alloc feature itself don't make sense. I've removed it. |
martin-hughes
approved these changes
Nov 10, 2026
martin-hughes
left a comment
martin-hughes
left a comment
Contributor
There was a problem hiding this comment.
Looks very sensible to me. I think this is an area where I'd like to get @IsaacWoods to double-check, since he knows the background of why the features were designed how they were - any thoughts Isaac?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For programs that build the interpreter from the tables themselves (Interpreter::new) and are built with a stable compiler, such as a UEFI boot manager reading the battery.
The allocator API, which needs nightly, is only used by the
platformmodule andInterpreter::new_from_platform. They are now behind aplatformfeature, on by default;default-features = false, features = ["aml"]builds with a stable compiler. CI builds that configuration, so it keeps working.This would allow me to use this crate with a stable compiler.