Repository navigation
Remove rustc_legacy_const_generics from unstable intrinsics - #2254
TechnoPorg wants to merge 1 commit into
Conversation
|
Thanks for the pull request, and welcome! The Rust Project has assigned @sayantn (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
| // Some of the functions extracted from mips-msa.h have immediate arguments between non-immediate arguments, | ||
| // but Rust const generics are not function arguments and cannot be expressed in a way that matches the header. | ||
| // For the sake of verification, rust const generics are treated as "the last arguments to a function". | ||
| arg_tys.sort_by(|arg1, arg2| arg1.is_const().cmp(&arg2.is_const())); | ||
|
|
There was a problem hiding this comment.
This feels gross, but then again, so does having const arguments in the middle of other non-const arguments 🤷♀️
dae9759 to
5505126
Compare
This comment has been minimized.
This comment has been minimized.
5505126 to
466752c
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
466752c to
aa8256e
Compare
There was a problem hiding this comment.
Is the lockfile update actually needed or can it be dropped?
|
API changes LGTM here, fyi @rust-lang/libs-ping since this went through lang FCP at rust-lang/rust#149654 but didn't go through libs FCP (I don't think it needs it). |
|
Agree with the analysis that this doesn't require libs FCP. Lang cares about feature stabilisation, we only care so much as it's part of the stable API and would need to be considered alongside it. |
As discussed in rust-lang/rust#149654 and #2248 (comment), intrinsics using this feature should not be stabilized. Since none of these architectures have stable intrinsics yet (unlike x86{_64}, ARM, WASM, and AArch64, which are excluded from this PR),
rustc_legacy_const_genericscan be removed without creating inconsistencies.LoongArch has also not been touched here as it appears to be handled in #2221.