Repository navigation
Conversation
djc
reviewed
Oct 12, 2026
rami3l
reviewed
Oct 12, 2026
Comment on lines
+1929
to
+1940
| cx.config | ||
| .expect(["rustup", "toolchain", "install", "stable"]) | ||
| .await | ||
| .is_ok(); | ||
| cx.config | ||
| .expect(["rustup", "toolchain", "install", "nightly"]) | ||
| .await | ||
| .is_ok(); | ||
| cx.config | ||
| .expect(["rustup", "default", "stable"]) | ||
| .await | ||
| .is_ok(); |
Member
There was a problem hiding this comment.
Nit: rustup default stable implies rustup toolchain install stable so you can only keep the former. Same thing for the next test.
14elias
force-pushed
the
feature/component-add-suggestion
branch
from
October 12, 2026 22:26
53d9b8c to
ad63aa3
Compare
djc
reviewed
Oct 13, 2026
| manifest: &Manifest, | ||
| cfg: &Cfg<'_>, | ||
| ) -> Option<Self> { | ||
| Self::for_action( |
Contributor
There was a problem hiding this comment.
IMO this callback solution isn't much better than the previous unabstracted solution. Suggest factoring out some helper functions instead.
14elias
force-pushed
the
feature/component-add-suggestion
branch
from
October 13, 2026 14:38
ad63aa3 to
39a0a0c
Compare
14elias
force-pushed
the
feature/component-add-suggestion
branch
from
October 13, 2026 14:52
39a0a0c to
951efbb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #5098
This change improves component suggestions when a requested component is not available in the active toolchain.
Previously, rustup could suggest a component removal from another toolchain, but it did not handle the add case. This patch makes component suggestions action-aware and adds a toolchain-based suggestion for rustup component add.