Repository navigation
ci: Resolve most zizmor findings as of zizmor@1.32.0 - #73
Merged
Conversation
This was referenced Nov 10, 2026
See: https://github.com/Swatinem/rust-cache/releases/tag/v2.9.1 See: https://github.com/Swatinem/rust-cache/compare/e18b497796c12c097a38f9edb9d0641fb99eee32..c19371144df3bb44fab255c43d04cbc2ab54d1c4 The only difference is the official release seems to have forgotten to update the changelog. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
hashcatHitman
force-pushed
the
ref-version-mismatch_and_stale-action-refs_and_superfluous-actions_and_unpinned-uses
branch
from
November 10, 2026 12:14
b564b51 to
a99d8c0
Compare
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
hashcatHitman
changed the title
ref-version-mismatch, stale-action-refs, superfluous-actions, and unpinned-useszizmor findings as of zizmor@1.32.0
Member
Author
|
r? crabwatch |
Member
Author
|
Well... I guess a coin flip as always. If this one lands on Marco (Heads (1)), I'm going to have to start rolling a 3-sided die to try to make it more fair. |
Member
Author
$ fend 1d2
1: 50.00% ##############################
2: 50.00% ##############################
$ fend roll 1d2
2The coin is afraid. It knows I'm watching. Well, anyway, cc @ubiratansoares |
ubiratansoares
approved these changes
Nov 10, 2026
hashcatHitman
deleted the
ref-version-mismatch_and_stale-action-refs_and_superfluous-actions_and_unpinned-uses
branch
November 10, 2026 13:14
hashcatHitman
moved this from zizmor PR opened
to Needs Policy Update
in t-crabwatch policy expansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pursuit of getting more
zizmorlints enforced acrossrust-langrepos throughcrabwatch, this PR fixes mostzizmorfindings as ofzizmor@1.32.0, using theauditorpersona. The lints that actually fired per-persona level are:regularpersona findings:ref-version-mismatch(See also: Solve theref-version-mismatchlint crabwatch#150)pedanticpersona findings:regularstale-action-refs(See also: Solve thestale-action-refslint crabwatch#151)excessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)superfluous-actionsanonymous-definition(Because coming up with names is hard and there is minimal benefit to this)concurrency-limits(Due to concerns about special cases. See also: Determine special cases forconcurrency-limitscrabwatch#107)auditorpersona findings:pedanticFor
Swatinem/rust-cache, it seems 2.9.1 may have been re-tagged at some point. You can compare the old commit and the new commit here: https://github.com/Swatinem/rust-cache/compare/e18b497796c12c097a38f9edb9d0641fb99eee32..c19371144df3bb44fab255c43d04cbc2ab54d1c4The only difference is changelog entries being added/removed.
For
dtolnay/rust-toolchain, it seems like re-tagging is the only tagging it knows. Fortunately,rustupis already installed onubuntu-latest,windows-latest, andmacos-latest. Switching to usingrustupdirectly clearsref-version-mismatchandstale-action-refs, with the added benefit of clearingsuperfluous-actions.The hash pin format is supported by tools like Dependabot and Renovate, which can update the pinned hashes and their associated comments. If you'd like help setting either of those up, let me know which you prefer, and if you'd like it in this PR or a new one. By default, I'd assume to set it up to only update GitHub Actions. See also: #67