Repository navigation
Conversation
rustbot
added
S-waiting-on-author
lambinoo
force-pushed
the
feat-comptime-read-files
branch
from
October 29, 2026 22:48
daef30d to
7da399f
Compare
oli-obk
requested changes
Oct 30, 2026
| } | ||
|
|
||
| /// Query data from non-local crates | ||
| query experimental_comptime_fetch_file(key: (CrateNum, &'tcx String)) -> Option<&'tcx [u8]> { |
Contributor
There was a problem hiding this comment.
Suggested change
| query experimental_comptime_fetch_file(key: (CrateNum, &'tcx String)) -> Option<&'tcx [u8]> { | |
| query experimental_comptime_fetch_file(key: (CrateNum, Symbol)) -> Option<&'tcx [u8]> { |
we usually try to encode such things as symbols to trivially copy them around, I'm not sure that's the right thing here, but we can start with it and optimize later
|
|
||
| specialization_enabled_in: bool, | ||
|
|
||
| // LazyTable maybe?? |
Contributor
There was a problem hiding this comment.
yea, definitely 😅 if the list gets large for anyone the linear search doesn't seem ideal
| Lock<FxHashMap<(ty::Clauses<'tcx>, &'tcx [ty::GenericArg<'tcx>]), ty::Clauses<'tcx>>>, | ||
|
|
||
| /// Cache of files that have been read by the const evaluator | ||
| pub experimental_comptime_files: Lock<FxIndexMap<&'tcx String, &'tcx [u8]>>, |
Contributor
There was a problem hiding this comment.
this cache shouldn't be necessary, queries have their result cached automatically
Contributor
Author
There was a problem hiding this comment.
Honestly, that was more so I could easily get access to all the read files when encoding the crate metadata. Is it possible to somehow fetch all the cached queries? Or maybe just have a Vec of filepath to re-query with the local crate num?
Edit: ahah, read your comments linearly and literally got the answer to my question two comments down 😆
| if let Some(value) = files.get(&key) { | ||
| Some(*value) | ||
| } else { | ||
| let file = std::fs::read(key).ok()?; |
Contributor
There was a problem hiding this comment.
need to check the file name against the command line argument list
Comment on lines
+774
to
+776
| let comptime_files = tcx.caches.experimental_comptime_files.borrow(); | ||
| let comptime_files = | ||
| comptime_files.iter().map(|(k, v)| ((*k).clone(), v.to_vec())).collect::<Vec<_>>(); |
Contributor
There was a problem hiding this comment.
can iterate the command line list here and call the query on each entry
| let comptime_files = | ||
| comptime_files.iter().map(|(k, v)| ((*k).clone(), v.to_vec())).collect::<Vec<_>>(); | ||
|
|
||
| // Should I somehow sort by filename here in case this does *anything* with the parallel frontend stuff or something? |
Contributor
There was a problem hiding this comment.
if the list comes from the CLI that isn't necessary, unless you wanna do a binary search instead of using a LazyTable (which may be sufficiently fast for small lists, and still ok for long lists, compared to the lazy table hash lookup)
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to tracking issue: #146922
r? @oli-obk
#goals/reflection > Reading files at comptime