Skip to content

Rollup of 2 pull requests - #164367

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pmUrlQY
Oct 15, 2026
Merged

rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pmUrlQY

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

charliermarsh and others added 4 commits October 14, 2026 17:54
* Print exit code if rustc fails in compiletest
* Update src/tools/compiletest/src/common.rs

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
…d-move-checks, r=TaKO8Ki

Skip move checks when the size limit is zero

## Summary

When the move-size limit is zero (i.e., the default), the individual large-assignment checks already return without doing anything. But we still traverse the reachable MIR blocks and monomorphize callee types before reaching those checks. This PR instead returns early from `check_moves`.
…e, r=bjorn3,jieyouxu

Print exit code if rustc fails in compiletest

In rare instances when rustc is broken, the exit code is the only feedback that we can get.
Example of such case rust-lang#157712 (comment).
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 15, 2026
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f77e393 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 15, 2026
@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 13s
Pushing 56df459 to main...

@rust-bors
rust-bors Bot merged commit 56df459 into rust-lang:main Oct 15, 2026
15 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3b13d3f (parent) -> 56df459 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 56df4595f93c41b7d956612e6211f9a274cc6a5d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-armhf-gnu: 56m 36s -> 1h 28m (+56.0%)
  2. test-x86_64-gnu-stdlib-semver-check: 18m 13s -> 8m 11s (-55.1%)
  3. test-x86_64-gnu-nopt: 1h 37m -> 2h 29m (+54.3%)
  4. dist-sparcv9-solaris: 1h 5m -> 1h 38m (+50.5%)
  5. dist-powerpc64le-linux-musl: 1h 8m -> 1h 39m (+44.2%)
  6. test-x86_64-gnu-gcc-core-tests: 18m 12s -> 10m 12s (-44.0%)
  7. test-x86_64-gnu-gcc: 1h 24m -> 48m 22s (-42.8%)
  8. test-various: 2h 19m -> 1h 21m (-41.2%)
  9. dist-riscv64-linux-musl: 1h 4m -> 1h 29m (+37.9%)
  10. test-x86_64-msvc-ext1: 2h 23m -> 1h 31m (-36.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#164332 Skip move checks when the size limit is zero b6d908eb98e8df8e26224621cc72ecde3e5084bd
(link)
#164351 Print exit code if rustc fails in compiletest d567d2664e73930231604a46ca864ff6ed801509
(link)

parent commit: 3b13d3fd58

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (56df459): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 2
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 2

Max RSS (memory usage)

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
12.6% [12.6%, 12.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 492.307s -> 489.662s (-0.54%)
Artifact size: 407.14 MiB -> 406.87 MiB (-0.07%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants