Repository navigation
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JohnTitor
reviewed
Nov 7, 2026
mu001999
force-pushed
the
note-for-non-exhaustive
branch
from
November 9, 2026 03:10
582a6a7 to
8c8379d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
mu001999
force-pushed
the
note-for-non-exhaustive
branch
from
November 9, 2026 05:57
8c8379d to
a12d2ae
Compare
Member
Author
|
@rustbot reroll |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue: #159713
Previous PR: #160918
This PR adds a note to the
unreachable_patternslint explaining that#[non_exhaustive]does not affect exhaustiveness checking within the defining crate when the type is a local enum with the attr#[non_exhaustive].