More stdarch regression tests by RalfJung · Pull Request #162342 · rust-lang/rust

RalfJung · 2026-09-05T18:44:34Z

This adds regression tests for

Poor codegen for AVX2 variable shift intrinsics: _mm256_sllv_epi32 and _mm256_srlv_epi32 #159831
Suboptimal codegen for _mm512_sllv_epi16 #159801
std::arch::x86_64::_mm_mulhi_epu16(vector, _mm_set1_epi16(scalar)) generates slow emulated path instead of pmulhuw (regressed in rustc 1.75) #159474
Performance regression: rustc failed to optimize specific x86-64 SIMD intrinsics after 1.75.0 #124216

Cc @folkertdev

try-job: test-x86_64-gnu-llvm*

RalfJung · 2026-10-24T13:13:47Z

@bors try

More stdarch regression tests try-job: test-x86_64-gnu-llvm*

rustbot · 2026-10-24T13:14:21Z

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 18 candidates

RalfJung · 2026-10-24T14:01:13Z

@bors try

More stdarch regression tests try-job: test-x86_64-gnu-llvm*

rust-bors · 2026-10-24T15:48:01Z

☀️ Try build successful (CI)
Build commit: ece48cb (ece48cbda30154751962fbbc350aae7ebd26cd6b)
Base parent: df87fa6 (df87fa6604e33760d4703cccc777a2281bf15a2d)

adwinwhite · 2026-10-27T07:44:46Z

@rustbot reroll

folkertdev

r? me

spotted a typo but otherwise looks good. r=me when fixed

View changes since this review

folkertdev · 2026-10-27T22:01:12Z

+    let shr3 = _mm256_srli_epi32::<3>(x);
+
+    // Things get moved around as `h2` is only needed if we don't return `Err`.
+    // There is an early return path in bewteen the two `_mm256_avg_epu8` calls.


Suggested change

// There is an early return path in bewteen the two `_mm256_avg_epu8` calls.

// There is an early return path in between the two `_mm256_avg_epu8` calls.

RalfJung · 2026-10-28T06:47:34Z

@bors r=folkertdev

rust-bors · 2026-10-28T06:47:37Z

📌 Commit efb8152 has been tentatively approved by folkertdev

It will be put into the queue for this repository once PR CI succeeds.

@folkertdev

…ests, r=folkertdev More stdarch regression tests This adds regression tests for - rust-lang#159831 - rust-lang#159801 - rust-lang#159474 - rust-lang#124216 Cc @folkertdev try-job: test-x86_64-gnu-llvm*

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@folkertdev

…ests, r=folkertdev More stdarch regression tests This adds regression tests for - rust-lang#159831 - rust-lang#159801 - rust-lang#159474 - rust-lang#124216 Cc @folkertdev try-job: test-x86_64-gnu-llvm*

…uwer Rollup of 23 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #165123 (Temporarily drop macos-26 jobs) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165123 (Temporarily drop macos-26 jobs) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@folkertdev

Rollup merge of #162342 - RalfJung:more-stdarch-regression-tests, r=folkertdev More stdarch regression tests This adds regression tests for - #159831 - #159801 - #159474 - #124216 Cc @folkertdev try-job: test-x86_64-gnu-llvm*

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#165032 (stdarch subtree update) - rust-lang/rust#165123 (Temporarily drop macos-26 jobs) - rust-lang/rust#165072 (Submodule update of rustc-perf) - rust-lang/rust#144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - rust-lang/rust#162342 (More stdarch regression tests) - rust-lang/rust#163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - rust-lang/rust#164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - rust-lang/rust#164916 (CI: rfl: move job forward to Linux v7.3) - rust-lang/rust#164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - rust-lang/rust#164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - rust-lang/rust#165083 (Gate `z` inline asm template modifier) - rust-lang/rust#165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - rust-lang/rust#161131 (Check associated const binding types) - rust-lang/rust#161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - rust-lang/rust#164315 (make powerpc `Complex` ABI GCC-compatible) - rust-lang/rust#164476 (Avoid ICE on None from prepare_vtable_segments) - rust-lang/rust#165003 (follow up for global-alloc-reentry test) - rust-lang/rust#165020 (Bless mir-opt panic-abort tests) - rust-lang/rust#165066 (skip max_repr_align in Layout::eq_abi) - rust-lang/rust#165080 (Syntactically allow C-variadics in parenthesized argument lists) - rust-lang/rust#165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - rust-lang/rust#165082 (Remove stability note from `rust_splat`)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 5, 2026

RalfJung force-pushed the more-stdarch-regression-tests branch 3 times, most recently from 3baa577 to 73396c9 Compare September 5, 2026 19:18

This comment has been minimized.

Sign in to view

RalfJung force-pushed the more-stdarch-regression-tests branch from 73396c9 to fb92db2 Compare September 7, 2026 11:49

RalfJung force-pushed the more-stdarch-regression-tests branch 2 times, most recently from 0b5f969 to 50511f7 Compare September 29, 2026 08:30

RalfJung force-pushed the more-stdarch-regression-tests branch from 50511f7 to 76c0bf2 Compare October 24, 2026 13:12

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 24, 2026

Auto merge of #162342 - RalfJung:more-stdarch-regression-tests, r=<try>

86fd280

More stdarch regression tests try-job: test-x86_64-gnu-llvm*

RalfJung marked this pull request as ready for review October 24, 2026 13:14

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2026

rustbot assigned adwinwhite Oct 24, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 24, 2026

This comment has been minimized.

Sign in to view

RalfJung force-pushed the more-stdarch-regression-tests branch from b719930 to 07de5af Compare October 24, 2026 14:01

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 24, 2026

Auto merge of #162342 - RalfJung:more-stdarch-regression-tests, r=<try>

ece48cb

More stdarch regression tests try-job: test-x86_64-gnu-llvm*

rustbot assigned jackh726 and unassigned adwinwhite Oct 27, 2026

folkertdev approved these changes Oct 27, 2026

View reviewed changes

rustbot assigned folkertdev and unassigned jackh726 Oct 27, 2026

RalfJung added 3 commits October 28, 2026 07:46

add regression tests for vector shift codegen issues

efdba89

add regression test for _mm_mulhi_epu16 issue

0f73f2e

add regression test for _mm256_avg_epu8 issue

efb8152

RalfJung force-pushed the more-stdarch-regression-tests branch from 07de5af to efb8152 Compare October 28, 2026 06:47

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

JonathanBrouwer mentioned this pull request Oct 28, 2026

Rollup of 22 pull requests #165095

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 23 pull requests #165130

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 22 pull requests #165151

Merged

rust-bors Bot merged commit 2c9bf98 into rust-lang:main Oct 29, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 29, 2026

RalfJung deleted the more-stdarch-regression-tests branch October 31, 2026 09:53

Navigation Menu

Repository navigation

More stdarch regression tests - #162342

More stdarch regression tests#162342
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
RalfJung:more-stdarch-regression-tests

RalfJung commented Sep 5, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

RalfJung commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 24, 2026

Uh oh!

This comment has been minimized.

RalfJung commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 24, 2026

Uh oh!

adwinwhite commented Oct 27, 2026

Uh oh!

folkertdev left a comment •

edited by rustbot

Loading

Uh oh!

folkertdev Oct 27, 2026

Uh oh!

RalfJung commented Oct 28, 2026

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	// There is an early return path in bewteen the two `_mm256_avg_epu8` calls.
	// There is an early return path in between the two `_mm256_avg_epu8` calls.

Conversation

RalfJung commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

RalfJung commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 24, 2026

Uh oh!

This comment has been minimized.

RalfJung commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 24, 2026

Uh oh!

adwinwhite commented Oct 27, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

folkertdev Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Oct 28, 2026

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RalfJung commented Sep 5, 2026 •

edited

Loading

folkertdev left a comment •

edited by rustbot

Loading