Repository navigation
[rustdoc] Correctly handle "conflict" between markdown case insensitive link definitions - #161785
GuillaumeGomez wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
65300b3 to
c10269d
Compare
|
Fixed typo. |
|
I think this behavior is likely not straightforward to fix. I'd like us to discuss in our team meeting before we move forward with the PR. Or at least I'd like to take a closer look myself first. |
|
We can do both. ;) |
This comment has been minimized.
This comment has been minimized.
|
It was discussed in today's rustdoc meeting and team seems ok with it. |
…finitions when what the user meant was to use the intra-doc link feature
c10269d to
8a30453
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Let's start the FCP then. @rfcbot fcp merge |
|
@rfcbot fcp merge |
|
@GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
As discussed in the last rustdoc team meeting. |
Fixes #80882.
The bug itself was pretty straightforward to fix: in case there is no matching (with case-sensitive check) link definition, we first look if it's an intra-doc link, and if not we fall back to the original (case insensitive) markdown handling (which
pulldown-cmarkdoes for us).The tricky part was to make sure that the intra-doc resolution would not emit warnings in this case, which forced me to add a new
emit_errorfield to a few types to handle it.r? @lolbinarycat