Repository navigation
Conversation
rustbot
added
the
S-waiting-on-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With rust-lang/rust#159374
#[link_ordinal]will no longer result in an unmangled symbol being generated in the import library. I changed the respective rule in the reference from specifying the contents of the import library to the actual opsem behavior that as I read it had already been implied (that it will call a symbol from the specified dylib with the specified ordinal irrespective of what unmangled symbol definitions or other import libraries exist at link time), but before rust-lang/rust#159374 was not actually true.