Repository navigation
Disable release-plz semver check - #745
Conversation
cargo-semver-checks enables all features when building rustdoc, which triggers the compile_error! for mutually exclusive max_level_* and release_max_level_* features.
|
We should fix the feature set instead, see log/.github/workflows/main.yml Line 133 in 95918ff |
|
the feature set can't be specified in release-plz today unfortunately. But I'm happy to implement this in the near future if you think it makes sense. Can the maintainers of this crate tell what they think about release-plz/release-plz#2291? |
|
For the log crate being able to specify the feature set is pretty much a must, I can leave a more detailed comment on release-plz/release-plz#2291 later. |
|
Thanks, that would be helpful! In the meantime, let's merge this PR so we unblock CI 👍 |
|
I don't do the releases, so I think @KodrAus is a better reviewer for this. |
|
We may find ourselves not being able to use semver checks here anyway, unless we can exempt specific modules. |
Fixes the failure in the release-plz job: https://github.com/rust-lang/log/actions/runs/40667352390/job/122745100514
release-plz runs
cargo-semver-checksto work out the next version.cargo-semver-checksbuilds rustdoc forlogwith all features enabled. That turns on everymax_level_*andrelease_max_level_*feature at once, and those features are mutually exclusive. The build then stops at thecompile_error!s insrc/lib.rs:This PR adds a
release-plz.tomlthat turns off the semver check for thelogpackage, so release-plz no longer runscargo-semver-checksand can open the release PR.