Skip to content

Disable release-plz semver check - #745

Merged
KodrAus merged 1 commit into
rust-lang:mainfrom
marcoienibot:release-plz-disable-semver-check
Oct 28, 2026
Merged

KodrAus merged 1 commit into
rust-lang:mainfrom
marcoienibot:release-plz-disable-semver-check

Conversation

@marcoienibot

@marcoienibot marcoienibot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the failure in the release-plz job: https://github.com/rust-lang/log/actions/runs/40667352390/job/122745100514

release-plz runs cargo-semver-checks to work out the next version. cargo-semver-checks builds rustdoc for log with all features enabled. That turns on every max_level_* and release_max_level_* feature at once, and those features are mutually exclusive. The build then stops at the compile_error!s in src/lib.rs:

error: multiple max_level_* features set
   --> src/lib.rs:379:1
error: multiple release_max_level_* features set
   --> src/lib.rs:399:1

This PR adds a release-plz.toml that turns off the semver check for the log package, so release-plz no longer runs cargo-semver-checks and can open the release PR.

cargo-semver-checks enables all features when building rustdoc, which
triggers the compile_error! for mutually exclusive max_level_* and
release_max_level_* features.
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

We should fix the feature set instead, see

- run: cargo hack test --feature-powerset --exclude-features max_level_off,max_level_error,max_level_warn,max_level_info,max_level_debug,max_level_trace,release_max_level_off,release_max_level_error,release_max_level_warn,release_max_level_info,release_max_level_debug,release_max_level_trace

@marcoieni

Copy link
Copy Markdown
Member

the feature set can't be specified in release-plz today unfortunately. But I'm happy to implement this in the near future if you think it makes sense. Can the maintainers of this crate tell what they think about release-plz/release-plz#2291?

@marcoieni
marcoieni marked this pull request as ready for review October 28, 2026 10:32
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

For the log crate being able to specify the feature set is pretty much a must, I can leave a more detailed comment on release-plz/release-plz#2291 later.

@marcoieni

marcoieni commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Thanks, that would be helpful! In the meantime, let's merge this PR so we unblock CI 👍

@Thomasdezeeuw
Thomasdezeeuw requested a review from KodrAus October 28, 2026 17:35
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

I don't do the releases, so I think @KodrAus is a better reviewer for this.

@KodrAus
KodrAus merged commit 5bc5545 into rust-lang:main Oct 28, 2026
14 checks passed
@KodrAus

KodrAus commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

We may find ourselves not being able to use semver checks here anyway, unless we can exempt specific modules. log needs to make its internals public to its macros, but they’re not considered public API and we do make changes to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants