Skip to content

Add kcmp_type constants - #5692

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:kcmp_type
Open

Add kcmp_type constants#5692
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:kcmp_type

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Nov 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@rustbot

rustbot commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in an Android module

cc @maurer

@GuillaumeGomez
GuillaumeGomez force-pushed the kcmp_type branch 3 times, most recently from f5c0801 to fc660e2 Compare November 3, 2026 10:50
@GuillaumeGomez

GuillaumeGomez commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Finally fixed the headers. \o/

Extra question: should we backport to the 0.2 branch once merged?

@GuillaumeGomez GuillaumeGomez changed the title Add kcmp_type enum Add kcmp_type constants Nov 3, 2026
@JohnTitor JohnTitor added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 7, 2026
@JohnTitor

JohnTitor commented Nov 7, 2026

Copy link
Copy Markdown
Member

Could you follow the PR checklist as per https://github.com/rust-lang/libc/blob/main/.github/PULL_REQUEST_TEMPLATE/libc_api.md?

Extra question: should we backport to the 0.2 branch once merged?

I've added stable-nominated so that it'll be included in next release.

@GuillaumeGomez
GuillaumeGomez force-pushed the kcmp_type branch 2 times, most recently from d4f223c to 25c0344 Compare November 7, 2026 18:09
@GuillaumeGomez

GuillaumeGomez commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

Could you follow the PR checklist as per https://github.com/rust-lang/libc/blob/main/.github/PULL_REQUEST_TEMPLATE/libc_api.md?

Done! Btw, shouldn't the semver add be done with a script based on the git diff? Doing it by hand seems a bit wasteful and error-prone, especially if there is no automated check.

I've added stable-nominated so that it'll be included in next release.

Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

O-android O-linux O-linux-like O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @rustbot @JohnTitor