Repository navigation
Conversation
Dirbaio
approved these changes
Nov 10, 2026
Dirbaio
left a comment
Dirbaio
left a comment
Member
There was a problem hiding this comment.
💯
(maybe a single "Invalid" error instead of 3 would be simpler? doesn't make much of a difference tho)
Contributor
Author
|
yeah, why not simplify it even further? I wonder if we should still include the number in the error, but i guess the caller has access to it anyway. |
robamu
marked this pull request as ready for review
November 10, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated and simplified error handling as suggested by @Dirbaio : There are dedicated error types for each trait now. Those are just unit errors.
The error is now a ZST. This removes the distinction between cases like an out-of-range error and an invalid number. But the distinction might not be worth a more complex error type.