Skip to content

Enable Style/FrozenStringLiteralComment #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduugg merged 1 commit into from
Sep 26, 2026
Merged

Enable Style/FrozenStringLiteralComment #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ Gemspec/RequireMFA:
Style/NegatedIf:
Enabled: false

# Disabling for now until it's clearer why we want this
Style/FrozenStringLiteralComment:
Enabled: false

#
# Leaving length metrics to human judgment for now
#
Expand Down
2 changes: 2 additions & 0 deletions packwerk-extensions.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

Gem::Specification.new do |spec|
spec.name = 'packwerk-extensions'
spec.version = '0.4.0'
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/skeleton/components/timeline/app/models/graphql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: false
# frozen_string_literal: true

module GraphQL
end
1 change: 1 addition & 0 deletions test/fixtures/skeleton/components/timeline/app/models/graphql/private_thing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: false
# frozen_string_literal: true

module GraphQL
class PrivateThing
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/skeleton/components/timeline/app/models/private_thing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: false
# frozen_string_literal: true

class PrivateThing
end
1 change: 1 addition & 0 deletions test/fixtures/skeleton/config/environment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# typed: false
# frozen_string_literal: true

# this file intentionally left blank
Loading