Skip to content

diagnostic_updater: publish a final status when the node shuts down - #682

Open
fujitatomoya wants to merge 1 commit into
ros:ros2from
fujitatomoya:feat/678-shutting-down-status
Open

fujitatomoya wants to merge 1 commit into
ros:ros2from
fujitatomoya:feat/678-shutting-down-status

Conversation

@fujitatomoya

Copy link
Copy Markdown

Updater publishes "Node starting up" as soon as a task is added, but had no
counterpart for the end of the node's life. The last published status was
whatever the last timer tick produced, and consumers had to rely on the
aggregator's stale timeout to notice the node was gone.

Add an optional shutting_down_status to the Updater constructors. When set,
a "Node shutting down" status with that level is published for every task.

C++: the status is published from a pre-shutdown callback on the node's
context. That runs before rcl_shutdown(), so rclcpp::ok() is still true and
the normal publish path works; it also covers Ctrl-C. The callback is removed
in the new destructor. setShuttingDownStatus() allows changing it at runtime.

Python: rclpy has no pre-shutdown hook (Context.shutdown() destroys the nodes
before running on_shutdown callbacks), so Updater.shutdown() must be called
explicitly before rclpy.shutdown(). Documented accordingly.

Default is disabled, so existing users see no behaviour change. Delivery is
best effort since the process usually exits right after.

Fixes #678

Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ct2034 i think that this is practical and reasonable use case, what do you think?

btw, if we take this patch or anything else in ros2 branch which is rolling, what is the backport policy for the downstream branches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diagnostic_updater: publish a final diagnostic status when the Updater is shut down (counterpart to starting_up_status)

1 participant