Repository navigation
diagnostic_updater: publish a final status when the node shuts down - #682
Open
fujitatomoya wants to merge 1 commit into
Open
fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya
commented
Nov 8, 2026
fujitatomoya
left a comment
Author
There was a problem hiding this comment.
@ct2034 i think that this is practical and reasonable use case, what do you think?
btw, if we take this patch or anything else in ros2 branch which is rolling, what is the backport policy for the downstream branches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updater publishes "Node starting up" as soon as a task is added, but had no
counterpart for the end of the node's life. The last published status was
whatever the last timer tick produced, and consumers had to rely on the
aggregator's stale timeout to notice the node was gone.
Add an optional shutting_down_status to the Updater constructors. When set,
a "Node shutting down" status with that level is published for every task.
C++: the status is published from a pre-shutdown callback on the node's
context. That runs before rcl_shutdown(), so rclcpp::ok() is still true and
the normal publish path works; it also covers Ctrl-C. The callback is removed
in the new destructor. setShuttingDownStatus() allows changing it at runtime.
Python: rclpy has no pre-shutdown hook (Context.shutdown() destroys the nodes
before running on_shutdown callbacks), so Updater.shutdown() must be called
explicitly before rclpy.shutdown(). Documented accordingly.
Default is disabled, so existing users see no behaviour change. Delivery is
best effort since the process usually exits right after.
Fixes #678