Repository navigation
Conversation
This will be used for the UHI pythonizations.
It uses the underlying GetLinearizedIndex(), and will be used for the UHI pythonizations.
Not included (for now): data coordinates using loc, and setting with an array.
hahnjo
requested review from
bellenot,
guitargeek,
hageboeck and
vepadulano
as code owners
November 10, 2026 16:55
Test Results 22 files 22 suites 3d 10h 31m 26s ⏱️ Results for commit 2391f8f. ♻️ This comment has been updated with latest results. |
hahnjo
commented
Nov 11, 2026
Expansion of the user argument (dictionaries, ellipsis) will come in the next commit.
hahnjo
force-pushed
the
hist-python-uhi
branch
from
November 11, 2026 14:11
5cd74a0 to
2391f8f
Compare
dpiparo
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two preparatory commits (implementing
SetBinContentwithstd::vector<RBinIndex>andRAxisVariant::IsValidIndex), and then pythonizations for UHI Indexing. Not included (for now): data coordinates usingloc, and setting with an array.