Skip to content

[tpython] Move TPython tests to bindings/tpython/test - #24087

Merged
guitargeek merged 2 commits into
root-project:masterfrom
guitargeek:move-tpython-tests
Nov 11, 2026
Merged

[tpython] Move TPython tests to bindings/tpython/test#24087
guitargeek merged 2 commits into
root-project:masterfrom
guitargeek:move-tpython-tests

Conversation

@guitargeek

@guitargeek guitargeek commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Closes #24044

@guitargeek
guitargeek requested a review from pcanal November 10, 2026 14:19
@guitargeek guitargeek self-assigned this Nov 10, 2026
@pcanal

pcanal commented Nov 10, 2026

Copy link
Copy Markdown
Member

@hageboeck @guitargeek Do we have an issue open and/or a solution for the 2 (likely somewhat transient) error that are shown in the CI run (but likely unrelated to this PR)? See https://github.com/root-project/root/actions/runs/42833009307/job/129887731996?pr=24087 and https://github.com/root-project/root/actions/runs/42833009307/job/129887732218?pr=24087

@github-actions

github-actions Bot commented Nov 10, 2026

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 11h 30m 55s ⏱️
 3 885 tests  3 884 ✅ 0 💤 1 ❌
72 254 runs  72 253 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit e9ae392.

@guitargeek

guitargeek commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@hageboeck @guitargeek Do we have an issue open and/or a solution for the 2 (likely somewhat transient) error that are shown in the CI run (but likely unrelated to this PR)? See https://github.com/root-project/root/actions/runs/42833009307/job/129887731996?pr=24087 and https://github.com/root-project/root/actions/runs/42833009307/job/129887732218?pr=24087

I'm investigating the tutorial-machine_learning-TMVA_SOFIE_GNN_Application failure on mac26. Indeed it's unrelated to this PR, and I have also seen it in other places.

@guitargeek
[tpython] Move the TPython tests from roottest to bindings/tpython/test
c230488 
Like this, they are only defined if `tpython=ON`. The macro and notebook
tests keep using the roottest machinery, like in tmva/sofie/test.
@guitargeek
[PyROOT] JIT-compile the PyException regression test
c63d0ad 
The test compiled a macro with ACLiC in root.exe, which needed
libROOTTPython to provide the Python library. Declaring the code to the
interpreter from Python instead makes the PyROOT regression tests
independent of TPython.
@guitargeek guitargeek changed the title [tpython] Move TPython and PyException tests to bindings/tpython/test [tpython] Move TPython tests to bindings/tpython/test Nov 11, 2026
@guitargeek
guitargeek merged commit 4051100 into root-project:master Nov 11, 2026
28 of 31 checks passed
@guitargeek
guitargeek deleted the move-tpython-tests branch November 11, 2026 13:42
@guitargeek

guitargeek commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.42

@root-project-bot

root-project-bot commented Nov 11, 2026

Copy link
Copy Markdown

Preparing to backport PR #24087 to branch 6.42 requested by guitargeek

@root-project-bot root-project-bot mentioned this pull request Nov 11, 2026
Merged
@root-project-bot

root-project-bot commented Nov 11, 2026

Copy link
Copy Markdown

This PR has been backported to branch 6.42: #24104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiparo dpiparo dpiparo approved these changes
@pcanal pcanal Awaiting requested review from pcanal
@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner
@vepadulano vepadulano Awaiting requested review from vepadulano vepadulano is a code owner

Assignees

@guitargeek guitargeek

Labels

in:Python Interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test requiring TPython not disabled when tpython=OFF

4 participants

@guitargeek @pcanal @root-project-bot @dpiparo