Repository navigation
[RF] Fix integrals of RooNormalizedPdf without normalization set - #24040
Open
guitargeek wants to merge 1 commit into
Open
guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Since 075d432, RooNormalizedPdf forwards the normalization set of an integral to the wrapped pdf. An empty normalization set then yields the integral of the unnormalized pdf, while getVal() is normalized. RooGenProdProj integrates the factors of a jointly normalized RooProdPdf term with an empty normalization set, so the cpu backend got the likelihood wrong when these integrals reached a RooNormalizedPdf. This happened for the jointly normalized factors themselves, like in the rf305_condcorrprod model of the HS3 test suite, and for normalized pdfs inside composite factors, like a nested RooProdPdf or a RooExtendPdf. Without a normalization set, the integral is now divided by the normalization integral of the RooNormalizedPdf. A new test compares the cpu backend to the scalar evaluation for the composite factors. 🤖 Done with the help of AI
Test Results 22 files 22 suites 3d 12h 19m 19s ⏱️ For more details on these failures, see this check. Results for commit 12c344f. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the final CPU backend bugfixes before the legacy NLL backend removal
Since 075d432, RooNormalizedPdf forwards the normalization set of an integral to the wrapped pdf. An empty normalization set then yields the integral of the unnormalized pdf, while getVal() is normalized.
RooGenProdProj integrates the factors of a jointly normalized RooProdPdf term with an empty normalization set, so the cpu backend got the likelihood wrong when these integrals reached a RooNormalizedPdf. This happened for the jointly normalized factors themselves, like in the rf305_condcorrprod model of the HS3 test suite, and for normalized pdfs inside composite factors, like a nested RooProdPdf or a RooExtendPdf.
Without a normalization set, the integral is now divided by the normalization integral of the RooNormalizedPdf. A new test compares the cpu backend to the scalar evaluation for the composite factors.
🤖 Done with the help of AI