Repository navigation
[rfile] Put(TNamed): forbid names containing '/' - #24036
Open
silverweed wants to merge 1 commit into
Open
silverweed wants to merge 1 commit into
silverweed wants to merge 1 commit into
Conversation
silverweed
force-pushed
the
rfile_tnamed_slash
branch
from
November 6, 2026 14:57
ca7a042 to
eaa6d8b
Compare
pcanal
reviewed
Nov 6, 2026
vepadulano
approved these changes
Nov 6, 2026
| EXPECT_THAT(ex.what(), testing::HasSubstr("Invalid object path")); | ||
| } | ||
| try { | ||
| file->Put(named3); |
Member
There was a problem hiding this comment.
This one is invalid because of the . character in the name? I'm not opposed to it, I just wonder because it's not included in the PR/commit description.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to accept TNamed objects with
/in their name, as they would be stored unexpectedly under a fully split path.To prevent this sort of confusion, we throw if the object has '/' in its name.