Repository navigation
Conversation
kEditor was exists before, but not supported in TROOT::SetEditorMode
When TLatex tool button was clicked before, any following mouse click on the pad insert new TLatex object keeping previous one with empty text. As a result - after many clicks dozens of dummy TLatex object were remain in the pad (just try gPad->ls()) Plus static fgText pointer used in TCreatePrimitives can store invalid pointer and may lead to ROOT crash. Therefore rewrite TCreatePrimitives::Text() functionality using `TPad::Interactive()` features. Like with objects dragging add temporary `TTextEditInteractive` instance which holds pointer on TLatex. Any keyboard press will be handled only when interactive object exists. Also avoid create multiple `TLatex` by multiple mouse clicking on pad. If latex was created, then second click will just finish editing of this latex object.
linev
requested review from
bellenot
and removed request for
dpiparo and
pcanal
November 6, 2026 13:22
silverweed
reviewed
Nov 6, 2026
silverweed
approved these changes
Nov 6, 2026
Test Results 22 files 22 suites 3d 15h 22m 30s ⏱️ For more details on these failures, see this check. Results for commit 85880db. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
TLatextool button was clicked before,any following mouse click on the pad insert new
TLatexobjectkeeping previous one with empty text. As a result - after many clicks
dozens of dummy
TLatexobject were remain in the pad (just trygPad->ls())Plus static
fgTextpointer used inTCreatePrimitivescan store invalid pointerand may lead to ROOT crash.
Therefore rewrite
TCreatePrimitives::Text()functionality usingTPad::Interactive()features. Like with objects dragging add temporaryTTextEditInteractiveinstance which holds pointer onTLatex. Any keyboardpress will be handled only when interactive object exists.
Also avoid create multiple
TLatexby multiple mouse clicking on pad.If latex was created, then second click will just finish editing of this latex object.