Skip to content

[cmake][win] Disable failing tests on x86 with VS 2026 v19.51 #24030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bellenot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[cmake][win] Disable failing tests on x86 with VS 2026 v19.51 #24030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/CAPITest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ TYPED_TEST(CppInterOpTest, CAPI_EnumFunctions) {
// Exercises the hand-written cppinterop_Evaluate C bridge. The C++ overload
// returning Cpp::Box has no C wrapper (NoCWrapper); C clients use this form.
TYPED_TEST(CppInterOpTest, CAPI_Evaluate) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
#ifdef EMSCRIPTEN_STATIC_LIBRARY
GTEST_SKIP() << "Test fails for Emscipten static library build";
#endif
Expand Down
24 changes: 24 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/FunctionReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionTemplatedDecls) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionReturnType) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<Decl*> Decls, SubDecls, TemplateSubDecls;
std::string code = R"(
namespace N { class C {}; }
Expand Down Expand Up @@ -872,6 +875,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,
}

TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_IsAllocator) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<Decl*> Decls;
std::string code = R"(
class Klass{
Expand Down Expand Up @@ -1570,6 +1576,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_OwnershipAttributes) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetDeallocType) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::string code = R"(
#include <new>
#include <stdlib.h>
Expand Down Expand Up @@ -1829,6 +1838,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetDeallocType) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetAllocType) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::string code = R"(
#include <new>
#include <stdlib.h>
Expand Down Expand Up @@ -2317,6 +2329,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetAllocType) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionSignature) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<Decl*> Decls;
std::string code = R"(
class C {
Expand Down Expand Up @@ -2433,6 +2448,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ExistsFunctionTemplate) {

TYPED_TEST(CPPINTEROP_TEST_MODE,
FunctionReflection_InstantiateTemplateFunctionFromString) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<const char*> interpreter_args = { "-include", "new" };
TestFixture::CreateInterpreter(interpreter_args);
std::string code = R"(#include <memory>)";
Expand Down Expand Up @@ -5448,6 +5466,9 @@ static int JitCallIntNullary(const char* ns, const char* fn) {

TYPED_TEST(CPPINTEROP_TEST_MODE,
FunctionReflection_DeducingThisBlogDeduplication) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
#ifdef EMSCRIPTEN
#if CLANG_VERSION_MAJOR > 21
GTEST_SKIP() << "Test fails for Emscripten builds using LLVM 22";
Expand Down Expand Up @@ -5543,6 +5564,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,

TYPED_TEST(CPPINTEROP_TEST_MODE,
FunctionReflection_DeducingThisBlogLambdaForwarding) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
#ifdef EMSCRIPTEN
#if CLANG_VERSION_MAJOR > 21
GTEST_SKIP() << "Test fails for Emscripten builds using LLVM 22";
Expand Down
9 changes: 9 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/InterpreterTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,
}

TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_ActivateInterpreter) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
#ifdef EMSCRIPTEN_STATIC_LIBRARY
GTEST_SKIP() << "Test fails for Emscipten static library build";
#endif
Expand Down Expand Up @@ -778,6 +781,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_EmscriptenExceptionHandling) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_CreateInterpreter) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
auto I = TestFixture::CreateInterpreter();
EXPECT_TRUE(I);
// Check if the default standard is c++14
Expand Down Expand Up @@ -1058,6 +1064,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, SignalHandler_MultipleInterpreters) {

#ifndef EMSCRIPTEN
TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_WrapperCacheIsPerInterpreter) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
if (TypeParam::isOutOfProcess)
GTEST_SKIP() << "Test fails for OOP JIT builds";

Expand Down
12 changes: 12 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/ScopeReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,9 @@
}

TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_GetNamed) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::string code = R"(namespace N1 {
namespace N2 {
class C {
Expand Down Expand Up @@ -1263,7 +1266,7 @@
explicit LazyDefinitionSource(std::map<std::string, std::string> Defs)
: Pending(std::move(Defs)) {}

void CompleteType(clang::TagDecl* Tag) override {

Check warning on line 1269 in interpreter/CppInterOp/unittests/CppInterOp/ScopeReflectionTest.cpp

View workflow job for this annotation

GitHub Actions / alma8 

by ‘virtual void {anonymous}::LazyDefinitionSource::CompleteType(clang::TagDecl*)’ [-Woverloaded-virtual]
auto It = Pending.find(Tag->getName().str());
if (It == Pending.end())
return;
Expand Down Expand Up @@ -1476,6 +1479,9 @@
}

TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_GetBaseClassOffsetWithAddress) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<Decl*> Decls;
// Layout fixtures own no resources and do not need custom copy/move members.
// NOLINTBEGIN(cppcoreguidelines-special-member-functions)
Expand Down Expand Up @@ -1675,6 +1681,9 @@

TYPED_TEST(CPPINTEROP_TEST_MODE,
ScopeReflection_InstantiateTemplateFunctionFromString) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<const char*> interpreter_args = {"-include", "new"};
TestFixture::CreateInterpreter(interpreter_args);
std::string code = R"(#include <memory>)";
Expand Down Expand Up @@ -1858,6 +1867,9 @@
}

TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_IncludeVector) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::string code = R"(
#include <vector>
#include <iostream>
Expand Down
6 changes: 6 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/TypeReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, TypeReflection_IsPackExpansionType) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, TypeReflection_IsSmartPtrType) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<const char*> interpreter_args = {"-include", "new"};
TestFixture::CreateInterpreter(interpreter_args);

Expand Down Expand Up @@ -819,6 +822,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, TypeReflection_IsVoidPointerType) {
}

TYPED_TEST(CPPINTEROP_TEST_MODE, TypeReflection_IsSameType) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
std::vector<Decl*> Decls;

std::string code = R"(
Expand Down
3 changes: 3 additions & 0 deletions interpreter/CppInterOp/unittests/CppInterOp/VariableReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,9 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,
CODE

TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_VariableOffsetsWithInheritance) {
#if defined(_MSC_VER) && _MSC_VER >= 1951 && !defined(_WIN64)
GTEST_SKIP() << "Disabled on Windows (x86). Needs fixing.";
#endif
#ifdef __EMSCRIPTEN__
GTEST_SKIP() << "This test crashes for Emscripten builds of CppInterOp";
#endif
Expand Down
Loading