Repository navigation
[eve7] Clear a scene's output after streaming it to a new connection - #24017
Merged
Merged
Conversation
REveManager::WindowConnect() streams the world and the mandatory scenes to the new connection with StreamElements() and sends the output to that connection only, but leaves it in the scene. The next change cycle then runs SendChangesToSubscribers(), which sends whatever output a scene holds to every subscriber: every client received the full StreamElements of the world and of the mandatory scenes once more, re-ran onEveManagerInit(), rebuilt the summary tree and closed the editor. The same happened in the MIR path that subscribes a viewer to a scene later, where SendSceneChanges() follows the direct send immediately, so the new client got the full stream twice. Added REveScene::ClearOutput(), which drops fOutputJson, fOutputBinary and fTotalBinarySize, and call it after each direct send in both paths. SendChangesToSubscribers() uses it for the clearing it already did. Verified in the browser on track_set_collection.C: the editor of the track set stays open across the first MIR after a page load; before the change the first MIR closed it. Assisted-by: Claude:Fable 5.1
linev
approved these changes
Nov 6, 2026
Test Results 22 files 22 suites 3d 10h 47m 24s ⏱️ Results for commit 8911b93. |
Member
|
/backport to 6.42 |
|
Preparing to backport PR #24017 to branch 6.42 requested by linev |
|
This PR has been backported to branch 6.42: #24033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix, to be backported to 6.42.
REveManager::WindowConnect() streams the world and the mandatory scenes to a new
connection and leaves the output in the scenes. The next change cycle then sends
that full stream to every client once more, and the client reinitializes every
controller via onEveManagerInit(), as if the initial connection were made. The MIR
path that subscribes a viewer to a scene later leaves the output in the same way,
so there the new client receives the stream twice.
The output is now cleared after each direct send, REveScene::ClearOutput(). Three
files, +19 lines.