Repository navigation
[civetweb] download and patch tarball with 588860e3 commit - #23948
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 16h 8m 4s ⏱️ Results for commit 5555ab9. ♻️ This comment has been updated with latest results. |
linev
changed the title
588860e3 commit
guitargeek
reviewed
Nov 3, 2026
Member
Author
|
Need to restart for clean build |
linev
force-pushed
the
civetweb_download
branch
2 times, most recently
from
November 4, 2026 11:38
afff951 to
015a3bb
Compare
linev
marked this pull request as ready for review
November 4, 2026 11:53
Contributor
|
Note that #23974 is now merged, so you could also add the |
Put in civetweb-588860e3.tar.gz code from 588860e3 commit and apply our patches to it. Then build with same commands as with git checkout Specify LCG and jsroot.gsi.de as alternative location Provide DOWNLOAD_DIR arg Add readme explaining how to create tarball from repository
When in ExternalProject_Add inside CMAKE_ARGS list of files or list of libraries should be specified - one have to use custom LIST_SEPARATOR to avoid conflict with sheel invocations by cmake For this particular case "|" symbol is used. Also disbale CIVETWEB_ENABLE_CXX compilation which is not used in ROOT
linev
force-pushed
the
civetweb_download
branch
from
November 5, 2026 09:35
015a3bb to
5555ab9
Compare
Member
Author
|
/backport to 6.42 |
|
Preparing to backport PR #23948 to branch 6.42 requested by linev |
|
This PR has been backported to branch 6.42: #24021 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git clone from repository is very "expensive" in terms of time and produced traffic.
In fact only very small core part of the civetweb code is used in the ROOT.
Therefore just create minimal tarball ourself, download it and apply same patches as for git repository
Trying also fix cmake warning when provide list of libs as argument - trying to use
LIST_SEPARATOR "|"argument