Repository navigation
Conversation
Test Results 21 files 21 suites 3d 12h 42m 31s ⏱️ Results for commit daaa384. ♻️ This comment has been updated with latest results. |
The Clang patch was added to run ROOT from non-accessible folders, see root-project#12409. We cannot upstream the change because such include directories behave weirdly, and it is better to not support it. This reverts commit b02e870.
34e4c93 to
daaa384
Compare
|
FYI @ktf as previously communicated via email |
|
This breaks ALICE. I think you should provide an alternative solution, no?
Ciao,
Giulio
…________________________________
From: Jonas Hahnfeld ***@***.***>
Sent: Thursday, 05 November 2026 11:40:37
To: root-project/root ***@***.***>
Cc: Giulio Eulisse ***@***.***>; Mention ***@***.***>
Subject: Re: [root-project/root] Revert "[clang] survive -Inon-accessible-directory:" (PR #23758)
[https://avatars.githubusercontent.com/u/1613332?s=20&v=4]hahnjo left a comment (root-project/root#23758)<#23758 (comment)>
FYI @ktf<https://github.com/ktf> as previously communicated via email
—
Reply to this email directly, view it on GitHub<#23758?email_source=notifications&email_token=AAACSMCF5XSSQOZH5B7FS7D5XRKKLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRVGU4DSNJZGAZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6655895902>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAACSMBXTQDW4JX6YMFZRB35XRKKLAVCNFSNUABEKJSXA33TNF2G64TZHMYTAOJZGQZTINJ3JFZXG5LFHM2TSMRTGI3TGNBUGSQXMAQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This is why we communicated the intent to drop this patch in September. As explained, non-accessible folders behave very weirdly and also this patch is not acceptable upstream. In order to make progress, we believe the right course of action is to drop it. In #12409, you already wrote
I think this is what you should be doing on your side. |
|
Indeed I though this was a different patch. I will check... |
The Clang patch was added to run ROOT from non-accessible folders, see #12409. We cannot upstream the change because such include directories behave weirdly, and it is better to not support it.
This reverts commit b02e870.