Repository navigation
Revert "[tmva][sofie] Pass senders/receivers as int64_t pointers in GNN tutorial" - #23580
Merged
Merged
Conversation
Test Results 24 files 24 suites 3d 21h 38m 6s ⏱️ For more details on these failures, see this check. Results for commit 4607024. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
sofie-fixup
branch
from
October 4, 2026 08:25
cf358bd to
ed88e95
Compare
guitargeek
force-pushed
the
sofie-fixup
branch
from
October 24, 2026 08:01
ed88e95 to
4607024
Compare
guitargeek
changed the title
vepadulano
approved these changes
Oct 29, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Changes LGTM. Please, do not merge before #23892 is merged and ensure the CI is fully green afterwards.
aaronj0
approved these changes
Oct 29, 2026
guitargeek
force-pushed
the
sofie-fixup
branch
from
October 29, 2026 18:58
4607024 to
f1614df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit guitargeek@bb5fa27.
The conversion of numpy int64 arrays to 'const int64_t*' parameters is now fixed in cppjit itself as of 45c723f, so the explicit
cppyy.ll.cast workaroundis not needed anymore. The tutorial passes the numpy arrays directly again.