Skip to content

[RF] Avoid shadowing/duplicating class member in RooIntegralMorph - #23062

Merged
guitargeek merged 1 commit into
root-project:masterfrom
ferdymercury:repeated
Nov 3, 2026
Merged

guitargeek merged 1 commit into
root-project:masterfrom
ferdymercury:repeated

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Aug 10, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

@ferdymercury
ferdymercury marked this pull request as ready for review August 10, 2026 13:13
@ferdymercury
ferdymercury requested a review from linev August 10, 2026 17:10
@github-actions

github-actions Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 8h 52m 15s ⏱️
 3 880 tests  2 962 ✅   0 💤   918 ❌
75 975 runs  73 197 ✅ 946 💤 1 832 ❌

For more details on these failures, see this check.

Results for commit ca098b7.

♻️ This comment has been updated with latest results.

Comment thread geom/geom/inc/TGeoPatternFinder.h Resolved
@ferdymercury
ferdymercury marked this pull request as draft August 11, 2026 05:46
@guitargeek guitargeek changed the title [RF,geom,TMVA] avoid shadowing parent class members [RF] Avoid shadowing/duplicating class member in RooIntegralMorph Nov 2, 2026
@guitargeek
guitargeek marked this pull request as ready for review November 2, 2026 06:28
@guitargeek

Copy link
Copy Markdown
Contributor

I have no idea about I/O conversion rules so I'll leave this PR as draft in case someone wants to take over ;)

Thanks! I took over this PR and reduced it to changes of data members that don't participate in IO (excluding the change to RooAbsOptTestStatistic because this class will anyway be removed in #23265).

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (note that I'm not approving my own work here, but a subset of the original PR)

@guitargeek
guitargeek merged commit 535d5e6 into root-project:master Nov 3, 2026
31 of 34 checks passed
@ferdymercury
ferdymercury deleted the repeated branch November 3, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants