Repository navigation
Let the workflows use the repository's own name - #34
Merged
Merged
Conversation
Contributor
|
@robocode-dev/rumble-moderators Moderation needs your decision for The required check stays pending. After reviewing, use |
Contributor
|
@robocode-dev/rumble-moderators Moderation needs your decision for The required check stays pending. After reviewing, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflows hard-coded two things that belong to this repository: the name
rumble-botswhen requesting the GitHub App token, and, in catalog verification, the names of the moderator and publisher Apps. They now use the name of the repository they run in, and the App names come from the optional repository variablesRUMBLE_MODERATOR_LOGINandRUMBLE_PUBLISHER_LOGIN, falling back to the current live Apps when unset.Nothing changes for this repository: the name resolves to
rumble-bots, no variable is set here, and the Apps, permissions and secrets stay the same. The files are now identical to the ones running in the test copyrumble-bots-test, where each App token was checked to reach only that repository and where a submission, its automatic merge and its catalog pull request were run end to end. Without the second change, the test publisher App is rejected as "not a publisher-created catalog PR".Because
.github/andmoderation/are code-owned by the moderators, this needs a moderator review.