Repository navigation
Bugfix - Close open Dependabot alerts - #16
Conversation
lucijaff
left a comment
There was a problem hiding this comment.
Non-blocking:
.travis.ymlis dead (PHP 7.1/7.2/hhvm can never satisfyphp-64bit >=8.3), so nothing runs on this or future bumps. Suggest deleting it or replacing it with a small Actions workflow (composer install,composer audit,make check-style,make test) on 8.3/8.4.
|
Thanks - replaced |
brianmuse
left a comment
There was a problem hiding this comment.
Looks good. The only require entry is still php-64bit >=8.3.0, so consumers see no change; every bump and removal is dev-only, and dropping the random_compat suggest is safe since NativeRandomByteGenerator calls core random_bytes(). The new workflow runs on plain pull_request on 8.3 and 8.4, uses no secrets, and the make lint, check-style and test targets it calls all exist; both jobs are green at this head.
This closes both open Dependabot alerts, both dev-only:
phpunit/phpunit^4.7→^12(CVE-2026-24765) andsquizlabs/php_codesniffer^2.3→^3.13.6(CVE-2026-67434). Bumps went throughcomposer require, not hand edits. There's nocomposer.lockhere (it's gitignored), so Dependabot only readscomposer.json.composer installwas already failing onmaster, because Composer 2 now refuses to load the vulnerable releases at all. PHPUnit 8.5 is EOL, so this goes to^12rather than its one-off CVE backport: the explicitphpunit/php-code-coveragepin is gone (PHPUnit pulls the matching version itself),phpunit.xml.distis migrated to the 12 schema, and.phpunit.cacheis ignored.paragonie/random_compatis dropped too, sincerandom_bytes()is core on the 8.3 this package requires..travis.ymlwas dead (PHP 7.1/7.2/hhvm can never satisfyphp-64bit >=8.3), so it's replaced by.github/workflows/build.yml:composer validate/install/audit,make lint,make check-styleandmake teston 8.3 and 8.4. Both jobs are green on this PR, and the README badge points at it.There are still no tests in this repo (the README has
- [ ] Tests), sophpunitjust reports "No tests executed".phpcs --standard=PSR2 src/ tests/passes all 47 files,composer validatepasses andcomposer auditis clean.