Repository navigation
fix(example): round camera values shown in examples to stop screenshot jitter - #4428
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ShowRegionDidChange and GetCenter show raw floats, which differ in the last digits from run to run (e.g.
38.91023300000003vs38.91023300000005), so Percy reports a diff every nightly. These examples now round lat/lon to 6 decimals and zoom, heading and pitch to 2. GetZoom gets the same zoom rounding.Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Doc screenshots from two consecutive nightlies (runs 40619903692 and 40805332916) differ only in this text for ShowRegionDidChange (
Latitude: 38.910233000000005/Longitude: -77.03608599999998vs38.91023300000003/-77.03608600000001). GetCenter currently showsLng: -73.97089500000001,Lat: 40.723279000000026.Component to reproduce the issue you're fixing