Skip to content

Enforce aggregate data-size limits after bracket and nested mutations - #1214

Merged
schungx merged 1 commit into
mainfrom
copilot/fix-max-map-size-enforcement
Nov 9, 2026
Merged

schungx merged 1 commit into
mainfrom
copilot/fix-max-map-size-enforcement

Conversation

Copilot AI commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Certain mutation routes for chaining operations fail to propagate changes, thus skipping the necessary data-size checks (for arrays, object maps etc.).

This fixes #1213

Behavior in Grain, which mirrors the incorrect Rhai engine behavior, is also fixed at the same time.

Copilot AI changed the title [WIP] Fix max map size enforcement for bracket and nested key insertion Enforce aggregate data-size limits after bracket and nested mutations Nov 8, 2026
Copilot AI requested a review from schungx November 8, 2026 14:57
@schungx
schungx marked this pull request as ready for review November 8, 2026 15:25
@schungx schungx added the bug label Nov 8, 2026
@schungx schungx added the vm Issues related to the Rhai Grain bytecodes compiler and VM. label Nov 9, 2026
@schungx
schungx force-pushed the copilot/fix-max-map-size-enforcement branch from ce95c44 to 5828a06 Compare November 9, 2026 06:23
@schungx
schungx force-pushed the copilot/fix-max-map-size-enforcement branch from 5828a06 to dc2d54c Compare November 9, 2026 06:30
@schungx
schungx merged commit 65baf54 into main Nov 9, 2026
55 checks passed
@schungx
schungx deleted the copilot/fix-max-map-size-enforcement branch November 9, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug vm Issues related to the Rhai Grain bytecodes compiler and VM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set_max_map_size not enforced for bracket insertion and nested key insertion; script continues running past the limit

2 participants