Skip to content

feat: add the GraphQL WebSocket client (G4, graphql-transport-ws) - #1594

Merged
jlouvel merged 3 commits into
3.0from
feat/graphql-g4-websocket-client
Nov 1, 2026
Merged

jlouvel merged 3 commits into
3.0from
feat/graphql-g4-websocket-client

fix: harden the GraphQL WebSocket client subscriptions

c033658
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 1, 2026 in 1m 5s

Annotations

Check warning on line 301 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "connection" which hides the field declared in "GraphqlWebSocketTransport".

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr9AHuD0oLhqhlT2&open=AaGKxr9AHuD0oLhqhlT2&pullRequest=1594

Check warning on line 103 in org.restlet.ext.graphql/src/test/java/org/restlet/ext/graphql/GraphqlWebSocketClientTestCase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()".

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr-aHuD0oLhqhlT6&open=AaGKxr-aHuD0oLhqhlT6&pullRequest=1594

Check warning on line 237 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "closed" which hides the field declared at line 199.

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGQpFruM0eP3oF9tawM&open=AaGQpFruM0eP3oF9tawM&pullRequest=1594

Check warning on line 318 in org.restlet.ext.graphql/src/test/java/org/restlet/ext/graphql/GraphqlWebSocketClientTestCase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotNull instead.

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr-aHuD0oLhqhlT8&open=AaGKxr-aHuD0oLhqhlT8&pullRequest=1594

Check warning on line 118 in org.restlet.ext.graphql/src/test/java/org/restlet/ext/graphql/GraphqlWebSocketClientTestCase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()".

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr-aHuD0oLhqhlT7&open=AaGKxr-aHuD0oLhqhlT7&pullRequest=1594

Check failure on line 171 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "payload" 4 times.

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr9AHuD0oLhqhlT1&open=AaGKxr9AHuD0oLhqhlT1&pullRequest=1594

Check warning on line 454 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern.

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr9AHuD0oLhqhlT3&open=AaGKxr9AHuD0oLhqhlT3&pullRequest=1594

Check warning on line 127 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this method into "Operation".

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr9AHuD0oLhqhlT5&open=AaGKxr9AHuD0oLhqhlT5&pullRequest=1594

Check failure on line 494 in org.restlet.ext.graphql/src/main/java/org/restlet/ext/graphql/GraphqlWebSocketTransport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AaGKxr9AHuD0oLhqhlT4&open=AaGKxr9AHuD0oLhqhlT4&pullRequest=1594