Repository navigation
ci(walletkit-maestro): default the Permit2 reset RPC to drpc - #661
Merged
Merged
Conversation
publicnode answers eth_getTransactionReceipt with a 403 ("Archive
requests require a personal token"), so the revoke was sent but the
step always reported a failure.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Claude finished @ignaciosantise's task in 46s —— View job Review in progress
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Permit2 allowance-reset step sends its revoke transaction. When it then asks publicnode for the receipt, the RPC answers with a 403:
For example, in the latest main run, the Android leg (job 124054042840) sent tx
0x29a49a7f…and then failed this way. The step doesn't fail the job, so it looks fine, but it never confirms the revoke. If one didn't land, nothing would notice, and the next run would skip theapprovestep it's meant to exercise.What
walletkit-build-and-maestro: thepolygon-rpc-urlinput now defaults tohttps://polygon.drpc.org.ci_e2e_walletkit.yamldoesn't pass this input, so all three legs pick up the new default. So does any other caller that doesn't pass its own RPC (e.g. pay-core).e2e-balance-check.ymlkeeps publicnode, because it only makeseth_call/eth_getBalancecalls, which still work.Test plan
Revoke successful in block 96441340. The wallet's USDT → Permit2 allowance is 0 afterwards. The matching Kotlin change is reown-kotlin#441.eth_chainId,eth_getTransactionCount,eth_gasPrice,eth_estimateGasfor the revoke, andeth_getTransactionReceiptfor a receipt publicnode refused.🧪 WalletKit - E2E Testsviaworkflow_dispatchon this branch: each leg's reset step logsRevoke successfulwith no 403.🤖 Generated with Claude Code