Skip to content

Pass a trigger's arguments only to a callable's positional parameters - #7961

Open
FarhanAliRaza wants to merge 3 commits into
mainfrom
farhan/focused-darwin-dx76ek-varargs
Open

FarhanAliRaza wants to merge 3 commits into
mainfrom
farhan/focused-darwin-dx76ek-varargs

Reject a callable whose keyword-only parameter has no default

f475bf2
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis failed Nov 22, 2026

Performance Regression: -5.65%

3 warnings

⚠️ 13 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 4 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 4 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

❌ 4 regressed benchmarks
✅ 142 untouched benchmarks
⏩ 8 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_route_matching[1000] 90 ms 96.4 ms -6.6%
❌ test_route_matching[100] 9.4 ms 10 ms -6.56%
❌ test_route_matching[10] 1.2 ms 1.3 ms -5.21%
❌ test_state_access[write_own] 122.2 ms 127.5 ms -4.22%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing farhan/focused-darwin-dx76ek-varargs (f475bf2) with main (df7f157)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩