Repository navigation
Honor an explicit --loglevel info when INFO is already the level - #7960
zeyadrabie wants to merge 1 commit into
Conversation
set_log_level() only writes REFLEX_LOGLEVEL when the level changes, so --loglevel info never reached the config. Both --loglevel callbacks now write an explicit level to REFLEX_LOGLEVEL.
[Medium impact] The PR appears safe to merge. SummaryBoth CLI callbacks now write an explicit
Reviews (1) · Last reviewed commit: "Honor an explicit --loglevel info when I..." · Reviewed by Greptile |
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="news/+explicit-loglevel-info.bugfix.md">
<violation number="1" location="news/+explicit-loglevel-info.bugfix.md:1">
P3: The root-package release rule requires a `performance` fragment for this production-code change, but this fragment is categorized as `bugfix`. Add the required `.performance.md` fragment or apply the documented `skip-changelog` waiver.
(Based on your team's feedback about root-package news fragments.)</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| @@ -0,0 +1 @@ | |||
| An explicit `--loglevel info` is no longer ignored when INFO is already the current level. Like any other `--loglevel` value, it now reaches `REFLEX_LOGLEVEL` and overrides a `loglevel` set in `rxconfig.py`. | |||
There was a problem hiding this comment.
P3: The root-package release rule requires a performance fragment for this production-code change, but this fragment is categorized as bugfix. Add the required .performance.md fragment or apply the documented skip-changelog waiver.
(Based on your team's feedback about root-package news fragments.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At news/+explicit-loglevel-info.bugfix.md, line 1:
<comment>The root-package release rule requires a `performance` fragment for this production-code change, but this fragment is categorized as `bugfix`. Add the required `.performance.md` fragment or apply the documented `skip-changelog` waiver.
(Based on your team's feedback about root-package news fragments.) </comment>
<file context>
@@ -0,0 +1 @@
+An explicit `--loglevel info` is no longer ignored when INFO is already the current level. Like any other `--loglevel` value, it now reaches `REFLEX_LOGLEVEL` and overrides a `loglevel` set in `rxconfig.py`.
</file context>
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
Part of #7850 (the
--loglevelhalf; #7947 handlesexport()).set_log_level()only writesREFLEX_LOGLEVELwhen the level changes, and it starts atINFO, so an explicit--loglevel infonever reached the config and could be overridden byrxconfig.pyorexport_for_deploy().This updates both
--loglevelcallbacks to write an explicit level toREFLEX_LOGLEVELand adds unit tests.set_log_level()is left unchanged since hosting commands call it with a default"info"even without a flag, which would otherwise overriderxconfig.py.All Submissions:
Type of change