Repository navigation
fix: collect the hooks and imports of the string form Bare renders for objects #7944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benedikt-bartscher
wants to merge
7
commits into
reflex-dev:main
Choose a base branch
from
benedikt-bartscher:bare-rendered-var-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+203
−87
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa98f6d
Collect the hooks and imports of the string form Bare renders for obj…
benedikt-bartscher ecd6607
Drop Bare's import override, which replaced a library's imports with …
benedikt-bartscher 31e402a
Build a Bare's rendered var once and reuse it
benedikt-bartscher 8c4780a
Collect the components of a Bare's rendered var too, not only those o…
benedikt-bartscher 5b67a35
Compare the complete hooks, custom code and refs in the rendered-comp…
benedikt-bartscher 6e1b1d0
Merge branch 'main' of github.com:reflex-dev/reflex into bare-rendere…
benedikt-bartscher e9ef4d7
Reach the components of a Bare's rendered var through its prop traver…
benedikt-bartscher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
packages/reflex-components-core/news/+bare-string-form-deps.bugfix.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| An object or boolean Var rendered as a child now brings along the hooks and imports of its `to_string()`, so a Var type with its own string form no longer breaks the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This cached property becomes stale when
Bare.contentsis reassigned._contents_vars()rebuilds the rendered var for a new contents identity, but imports, refs, custom code, dynamic imports, and compiler traversal still use the old component list; avoid caching this derived property or invalidate it whenevercontentschanges.Prompt for AI agents