Skip to content

Don't wait in Thread.join(timeout) when draining supervised output - #7855

Merged
masenf merged 2 commits into
mainfrom
fix/windows-supervisor-lingering-pipe
Nov 12, 2026
Merged

masenf merged 2 commits into
mainfrom
fix/windows-supervisor-lingering-pipe

Close the output pump's pipe even when forwarding raises

67d13d5
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis failed Nov 11, 2026

Performance Regression: -1.44%

1 warning

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 148 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_state_access[get_handler] 69.2 ms 72.7 ms -4.82%
❌ test_process_event_burst_independent_tokens[1] 2.7 ms 2.9 ms -4.79%
⚡ test_route_matching[1000] 50.5 µs 47.8 µs +5.65%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/windows-supervisor-lingering-pipe (67d13d5) with main (99cf380)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (1ad20b0) during the generation of this report, so 99cf380 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩