Repository navigation
Conversation
7d4d9e33
changed the title
boringssl either require sse2 as baseline or disable assembly optimizations, otherwise compilation will fail
latest cross image seems to not include clang (headers) anymore, so we have to install them ourselves
just in case anyone needs it
follow upstream
…onfig i am not sure this can be touched, comment for that packages kept for reference later on
7d4d9e33
commented
Oct 25, 2026
| ] | ||
|
|
||
| [target.x86_64-pc-windows-gnu] | ||
| image = "ghcr.io/cross-rs/x86_64-pc-windows-gnu:main" |
Contributor
Author
There was a problem hiding this comment.
The main reason i used main version instead of default cross-rs image is to be able to pick newer nasm, otherwise compilation will fail because curent stable cross-rs image uses very old version of Ubuntu (18.04) thus nasm also outdated.
Linux targets seems to not suffer from this issue.
Same goes for i686-pc-windows-gnu target
musl-tools still required outside cross-rs environment
usually not needed on GitHub Actions, but just to be safe
didn't review changes properly again...
it needs libstdc++-6.dll (btls requires this) and possibly others now which cannot be easily provided within artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Cleaned up and split GitHub Actions setup, added
cross-rs, and introduced a few new build targets.Changes
Workflow Split & Cleanup:
pull-request.ymlby splitting tests intocode-test.ymland lints/formatting intolint-check.yml. Both run onpush.actions-rust-lang/rustfmtaction instead of runningrustfmtdirectly onlint-check.ymlfor its GitHub problem matcher output in the UI.parse-version.yml).pr-*.ymlworkflows so PR workflow runs don't clutter up regular push runs in GitHub Actions history.Artifacts & Releases:
build-artifacts.yamlnow just uploads workflow artifacts on push/PR instead of creating GitHub releases.debugprofile builds alongsidereleaseinbuild-artifacts.yaml.create-release.ymlwithworkflow_dispatchto manually bundle release archives and create a draft release on GitHub when needed.Cross-Compilation (
cross-rs) & Target Updates:Cross.tomland switched compilation steps to usecross. This makes cross-compiling easier in general and avoids header/LLVM conflict issues during MinGW builds on Ubuntu environments.x86_64-pc-windows-gnu(Windows 10+ 64-bit)i686-unknown-linux-musl(Linux 32-bit musl)i586-unknown-linux-musl(Older Linux 32-bit musl, disabled for now due to low demand)i686-pc-windows-gnu(Windows 10+ 32-bit, disabled for now due toboring-sys2build failures)x86_64-unknown-linux-musl,aarch64-unknown-linux-musl,armv7-unknown-linux-musleabihf) were kept and now build throughcross.Notes
create-release.ymlhasn't been tested on draft release creation yet, but I tested generating the release artifact bundle containing all files.