Skip to content

Limit Sentinel ACL to the hello channel - #4247

Merged
dwdougherty merged 2 commits into
redis:mainfrom
yinon-bit:codex/vdp-4549-sentinel-acl-guidance
Oct 13, 2026
Merged

dwdougherty merged 2 commits into
redis:mainfrom
yinon-bit:codex/vdp-4549-sentinel-acl-guidance

Conversation

@yinon-bit

@yinon-bit yinon-bit commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Relates to VDP-4549.

Replace the broad allchannels permission in the ACL example with access to the reserved __sentinel__:hello channel, matching the Sentinel security guidance.


Note

Low Risk
Documentation-only changes with no runtime or configuration impact.

Overview
Documentation-only update to align Sentinel ACL guidance with least-privilege Pub/Sub access and stronger security warnings (VDP-4549).

In acl.md, the example Sentinel ACL SETUSER line no longer uses allchannels; it now uses resetchannels &__sentinel__:hello so the sentinel user can only access the reserved hello channel.

In sentinel.md, the existing __sentinel__:hello warning is expanded to describe forged HELLO messages (redirecting Sentinels, possible exposure of master credentials, spurious failovers/DoS) and adds explicit ops guidance: the doc change does not fix deployments—operators should review ACL users on monitored nodes, including default, and ensure no non-Sentinel user can publish or subscribe to __sentinel__:hello.

Reviewed by Cursor Bugbot for commit ec19100. Bugbot is set up for automated code reviews on this repo. Configure here.

VDP-4549: replace broad allchannels access with the reserved __sentinel__:hello channel in the Sentinel ACL example.
Explain how forged HELLO messages can redirect Sentinels and expose configured master credentials. Clarify that existing ACLs are unchanged and should be reviewed.
@dwdougherty dwdougherty self-assigned this Oct 13, 2026
@dwdougherty dwdougherty added dev oss Redis Open Source labels Oct 13, 2026

@dwdougherty dwdougherty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @yinon-bit. Approved.

@dwdougherty
dwdougherty merged commit d1b865f into redis:main Oct 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev oss Redis Open Source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants