Repository navigation
Conversation
- Re-color the Mocha 'spec' reporter output for dark terminal themes: passing test titles, failure stack traces and durations are rendered in 'bright black' (ANSI 90), which is nearly invisible on dark themes like VS Code Dark Modern (#3b3b3b on #1f1f1f); they now use the terminal's default foreground color, keeping the colored checkmarks, diffs and summaries - Add a shared createMocha() factory (test/mocha-config.ts) combining the options common to all test kinds (spec reporter, tdd ui, colors, palette) with the test-kind specific ones; drop the dead 'require: [./helper.js]' option (CLI-only, and the file does not exist) - Stop setting NODE_OPTIONS in build/run-tests.cjs and delete the dead test/bootstrap.ts: VS Code strips NODE_OPTIONS from the extension host environment, so the ESM-to-CJS alias bootstrap never actually loaded there (the extension host, Node.js >= 22.12, natively require()s the ESM-only dependencies); the variable only made the Electron main and renderer processes print "Most NODE_OPTIONs are not supported in packaged apps" errors - Disable the GPU of the test VS Code instance: it renders with software rendering anyway, and this prevents "'--ozone-platform=wayland' is not compatible with Vulkan" errors on Wayland sessions - Load 'istanbul' and 'remap-istanbul' lazily in test/coverage.ts: loading the test-only istanbul package on every run triggered a Node.js circular-dependency warning; it is now loaded only when coverage data was actually collected - Log the 'Installed extensions' debug list from the activation test only when VERBOSE is set Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com> Assisted-By: OpenCode: GLM 5.3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6237 +/- ##
=======================================
Coverage 53.71% 53.71%
=======================================
Files 131 131
Lines 12007 12007
Branches 2699 2718 +19
=======================================
Hits 6449 6449
Misses 5552 5552
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-By: OpenCode: GLM 5.3