Repository navigation
Fix Windows CI: normalize CRLF in printer tests from #8881 and #8886 - #8900
Merged
samsonasik merged 1 commit intoOct 31, 2026
Merged
Conversation
rectorphp#8886 On Windows, Git checks out the test files with CRLF, so the heredoc input contains \r\n. Format-preserving printing correctly keeps those line endings, so the output is normalized before comparing with LF-only expectations. Amp-Thread-ID: https://ampcode.com/threads/T-01a1908f-48b6-7423-b4cd-641c531e141f
samsonasik
approved these changes
Oct 31, 2026
Member
|
Thank you @ondrejmirtes , let's give it a try 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Git checks out the test files with CRLF, so the heredoc input contains \r\n. Format-preserving printing correctly keeps those line endings, so the output is normalized before comparing with LF-only expectations.