Repository navigation
fix: added default protocol in the endpoint input field - #172
Closed
AbhishekPAnil wants to merge 1 commit into
Closed
AbhishekPAnil wants to merge 1 commit into
AbhishekPAnil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how reconciliation service endpoints are handled by automatically adding the
https://protocol if a user omits it, making the system more user-friendly and robust. It also updates the user interface to clarify this behavior and adds a test to ensure the new logic works as expected.Endpoint normalization improvements:
normalizeEndpointmethod toReconciliationServicethat automatically prependshttps://to endpoints missing a protocol. The constructor now uses this method to standardize endpoints. [1] [2]User interface updates:
ReconciliationServiceInput.jsxto inform users thathttps://is assumed if omitted.Testing enhancements:
ReconciliationServiceInput.test.jsxto verify that endpoints without a protocol default tohttps://.