Skip to content

fix: added default protocol in the endpoint input field - #172

Closed
AbhishekPAnil wants to merge 1 commit into
reconciliation-api:masterfrom
culturecreates:task/issue-110
Closed

AbhishekPAnil wants to merge 1 commit into
reconciliation-api:masterfrom
culturecreates:task/issue-110

Conversation

@AbhishekPAnil

Copy link
Copy Markdown
Contributor

This pull request improves how reconciliation service endpoints are handled by automatically adding the https:// protocol if a user omits it, making the system more user-friendly and robust. It also updates the user interface to clarify this behavior and adds a test to ensure the new logic works as expected.

Endpoint normalization improvements:

  • Added a static normalizeEndpoint method to ReconciliationService that automatically prepends https:// to endpoints missing a protocol. The constructor now uses this method to standardize endpoints. [1] [2]

User interface updates:

  • Updated the endpoint input field's placeholder in ReconciliationServiceInput.jsx to inform users that https:// is assumed if omitted.

Testing enhancements:

  • Added a test to ReconciliationServiceInput.test.jsx to verify that endpoints without a protocol default to https://.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant