Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-2049
These are deprecations that came from the 2.4.6 and 2.4.7 magento updates. There's also a few from the 2.4.9 update that I'm adding to the backlog for the 6.x release.
This changes:
cart.items->cart.itemsV2, with a page size of 9999. The code inuseCarthas been changed such that it still supports the old query, in case you've overwritten it and won't switch to the V2 query for whatever reason. This keeps it fully backwards compatible.uidversions of the deprecatedidvariables in this query as well without removing the old ones. Note that the blade files also ask for these new ones now, but overwritten blade files or other custom queries will keep working.uidand__typenamefields next to the deprecated fields in the product graphql fragment.
These backwards compatibilities are also relevant for the checkout-theme overrides, specifically the UID ones. While I've made branches there for this, I don't think we actually want to add version constraints there, so we should wait for 6.x there as well.
This doesn't touch the deprecated order data, because this may not be backwards compatible for every payment provider yet. That will have to be revised in 6.x as well.