Repository navigation
Fix Argon2 PHC parameter order - #562
Merged
ranisalt merged 3 commits intoOct 17, 2026
Merged
Conversation
ranisalt
reviewed
Oct 16, 2026
Owner
|
You will also need to rebase from master because I can do it easily if you prefer Edit: doing it myself to bump the version faster |
ranisalt
force-pushed
the
codex/fix-phc-argon2-param-order-559
branch
from
October 17, 2026 19:31
dea7631 to
aed30e4
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash()builds Argon2 parameters as{ m, t, p }. The PHC formatter serializes parameter keys in insertion order, so generated hashes now follow the Argon2m,t,psequence.Evidence
m=65536,p=4,t=3; the PHC string specification requiresm,t,p.m=65536,t=3,p=4for the supported hash variants, including the optionaldataparameter. Static inspection confirms the formatter preserves the parameter object's key order.Merge Danger
Door: Two-way
Existing hashes remain accepted by the parser; the digest and salt are unchanged.
Blast Radius: Narrow
Only the serialized parameter order changes.