Skip to content

literals: reject binary BigInteger literals on net8.0 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 1 commit into from
Oct 9, 2026
Merged

literals: reject binary BigInteger literals on net8.0 #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Ramstack.Parsing/Literal.Number.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,16 @@ public static Parser<T> Number<T>(string? name, NumberKind kind = NumberKind.Aut

#if NET8_0_OR_GREATER
if (kind == NumberKind.BinaryNumber)
{
#if NET8_0
if (typeof(T) == typeof(BigInteger))
throw new ArgumentException(
$"Number kind {kind} is not supported for BigInteger.",
nameof(kind));
#endif

return new NumberLiteral<T, BinaryNumberLiteralKind>(name ?? "binary number", NumberStyles.BinaryNumber);
}
#endif

throw new ArgumentException(
Expand Down
Loading