Repository navigation
parsers: correct Unicode and culture-aware string matching - #31
Merged
Merged
Conversation
Normalize OrdinalIgnoreCase bucket keys for both literals and input so OneOf recognizes equivalent characters beyond simple upper/lower pairs. Match culture-aware candidates without first-character bucketing and consume the source length returned by CompareInfo.IsPrefix rather than the literal length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OneOfcould miss Unicode case equivalents because its first-character lookup only included the literal's upper/lower forms:OrdinalIgnoreCasenow normalizes lookup keys for both literals and input. Culture-aware comparisons check candidates without filtering by the first character.LandOneOfalso:CompareInfo.IsPrefixto consume the actual matched source length, which can differ from the literal length.This changes
L's previous behavior: changing the current culture no longer affects an existing parser.