Repository navigation
script: move child nodes into a fragment instead of spreading them - #99
Merged
Merged
Conversation
The innerMorph/outerMorph fallback and the outerSync fallback for HTMX 1.9.x and 2.x spread the response's child nodes into replaceChildren and replaceWith. Engines limit the number of call arguments: about 125,000 in Chromium, 500,000 in Firefox and 65,536 in Safari. A larger response made handleSwap throw a RangeError, and HTMX logged it and fell back to the default swap style: outerMorph inserted the response inside the target, and outerSync nested the new element inside the target, whose attributes had already been synchronized. Move the nodes into a DocumentFragment and pass it as a single argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spreading child nodes into
replaceChildren/replaceWithcan throw aRangeErrorwhen there are too many of them, because engines limit the number of call arguments:Fix:
Move the nodes into a
DocumentFragmentand pass it as a single argument. This is a precaution against a potential error rather than a fix for a reported issue.